Dev Log - r631

Tracking reviki development

[2008-03-30] Atomic commit for adding attachment and link

For a while now we've had uploading an attachment split across two commits, one creating the PageName-attachments directory (if requried) and the other committing the attachment file. As of r619 it got worse - we now automatically add a link to the attachment to the associated page.

Time to tidy SVNPageStore/BasicSVNOperations to make it easy to create the directory and the file in the same commit. This will be needed for RefactorRename too.

Update (r629): The mutator methods on BasicSVNRepository now do less to give the SVNPageStore more control over combining modifications. All the operations needed to upload an attachment are now a single commit. Having to assemble all the actions up-front - because SVNRepository isn't re-entrant - leads to a clumsy separation of figuring out if something needs to be done and doing it - suspect we could pull out a prepare / perform interface. Revisit for RefactorRename.